refactor: rename RowIdTreeMap to RowAddrTreeMap #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanghua
force-pushed
the
rename-RowIdTreeMap
branch
from
d614f70 to
8911b12
Compare
yanghua
force-pushed
the
rename-RowIdTreeMap
branch
2 times, most recently
from
4d5847e to
8ee0645
Compare
yanghua
force-pushed
the
rename-RowIdTreeMap
branch
from
8ee0645 to
067240c
Compare
yanghua
commented
Nov 27, 2025
rust/lance-core/src/utils/mask.rs
Outdated
Comment on lines
363
to
364
| /// A collection of row addresses and row ids(for stable row id mode, | ||
| /// and would split it into another structure). |
Collaborator
Author
There was a problem hiding this comment.
Added some comments to describe a temporary solution. Will split the responsibility of the row ID.
Contributor
There was a problem hiding this comment.
this sounds a bit confusing to me, what about:
/// A collection of row addresses.
///
/// Note: For stable row id mode, this may be split into a separate structure in the future.
Collaborator
Author
|
Renaming some variables may not be thorough. Will recheck them when introducing a new collection for row ID. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
jackye1995
reviewed
Dec 2, 2025
yanghua
force-pushed
the
rename-RowIdTreeMap
branch
from
1e348f4 to
06312eb
Compare
Collaborator
Author
|
@jackye1995 addressed |
jackye1995
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.